feat(sbb-chip-group): initial implementation #3382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
target: 2.x
pr: peer review required
TomMenga
added
the
pr: lead review required
# Conflicts: # src/elements/autocomplete/autocomplete-base-element.ts
DavideMininni-Fincons
requested changes
Feb 4, 2025
| @@ -30,6 +30,11 @@ import style from './autocomplete-base-element.scss?lit&inline'; | |||
| */ | |||
| const ariaRoleOnHost = isSafari; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Should we have an events property?
| let input: HTMLInputElement; | ||
| let focusStep: HTMLInputElement; | ||
|
|
||
| describe('basic interactions', () => { |
There was a problem hiding this comment.
Suggested change
| describe('basic interactions', () => { | |
| describe('sbb-chip-group', () => { |
possibly adding a nested described with 'basic interaction'
| }); | ||
| }); | ||
|
|
||
| describe.only('with autocomplete', () => { |
There was a problem hiding this comment.
Suggested change
| describe.only('with autocomplete', () => { | |
| describe('with autocomplete', () => { |
| }; | ||
|
|
||
| // TODO | ||
| export const WithAutoComplete: StoryObj = { |
There was a problem hiding this comment.
MEMO: remove todo
Suggested change
| export const WithAutoComplete: StoryObj = { | |
| export const WithAutocomplete: StoryObj = { |
| import style from './chip-group.scss?lit&inline'; | ||
|
|
||
| /** | ||
| * Describe the purpose of the component with a single short sentence. |
There was a problem hiding this comment.
Replace this placeholder text
Comment on lines
+51
to
+71
| const toRemove = [...oldValue]; | ||
| for (const c of value) { | ||
| if (toRemove.includes(c)) { | ||
| toRemove.splice(toRemove.indexOf(c), 1); | ||
| } | ||
| } | ||
| toRemove.forEach((value) => | ||
| this._chipElements() | ||
| .find((c) => c.value === value) | ||
| ?.remove(), | ||
| ); | ||
|
|
||
| // Subtract from the new 'value' what was already present | ||
| // The result are the new chips to add (handle duplicates) | ||
| const toAdd = [...value]; | ||
| for (const c of oldValue) { | ||
| if (toAdd.includes(c)) { | ||
| toAdd.splice(toAdd.indexOf(c), 1); | ||
| } | ||
| } | ||
| toAdd.forEach((c) => this._createChipElement(c)); |
There was a problem hiding this comment.
Suggestion: could the usage of Set and Set's method (difference, insersection, etc) improve this code?
| @@ -0,0 +1,52 @@ | |||
| import { html } from 'lit'; | |||
There was a problem hiding this comment.
Remove placeholder comments from this file
|
|
||
| ## Accessibility | ||
|
|
||
| The `sbb-chip-group` follows the `grid` pattern; |
There was a problem hiding this comment.
infos are missing, or the ; must be replaced with .
Comment on lines
+37
to
+47
| The `sbb-chip-group` has a `negative` variant. If within a `sbb-form-field`, the properties automatically sync. | ||
|
|
||
| ```html | ||
| <sbb-form-field negative> | ||
| <sbb-chip-group name="field-name"> | ||
| <sbb-chip value="Value 1"></sbb-chip> | ||
| ... | ||
| <input /> | ||
| </sbb-chip-group> | ||
| </sbb-form-field> | ||
| ``` |
There was a problem hiding this comment.
This can go in ## Style maybe?
| import { i18nChipDelete } from '@sbb-esta/lyne-elements/core/i18n/i18n'; | ||
|
|
||
| /** | ||
| * Describe the purpose of the component with a single short sentence. |
There was a problem hiding this comment.
Remove this placeholder text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open topics
Preflight Checklist
Issue
This PR Closes #2761
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
sbb-chip-groupsbb-chipBrowsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information